Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fabric-lib-go for bccsp, metrics, flogging #404

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

denyeart
Copy link
Contributor

The following packages are being moved from fabric to fabric-lib-go so that they can be shared across fabric and fabric-ca:

  • github.com/hyperledger/fabric/bccsp
  • github.com/hyperledger/fabric/common/flogging
  • github.com/hyperledger/fabric/common/metrics

This commit updates fabric-ca to use the common code in fabric-lib-go.

The fabric-ca dependency on fabric is no longer needed. That's good!

Also ran goimports to clean up imports.

The following packages are being moved from fabric to fabric-lib-go
so that they can be shared across fabric and fabric-ca:

- github.com/hyperledger/fabric/bccsp
- github.com/hyperledger/fabric/common/flogging
- github.com/hyperledger/fabric/common/metrics

This commit updates fabric-ca to use the common code in fabric-lib-go.

The fabric-ca dependency on fabric is no longer needed. That's good!

Also ran goimports to clean up imports.

Signed-off-by: David Enyeart <[email protected]>
@denyeart
Copy link
Contributor Author

Go approval in fabric repo to push down the dependency to fabric-lib-go, I'll go ahead and merge.

@denyeart denyeart merged commit e2249aa into hyperledger:main Feb 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant