Use fabric-lib-go for bccsp, metrics, flogging #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following packages are being moved from fabric to fabric-lib-go so that they can be shared across fabric and fabric-ca: - github.com/hyperledger/fabric/bccsp - github.com/hyperledger/fabric/common/flogging - github.com/hyperledger/fabric/common/metrics This commit updates fabric-ca to use the common code in fabric-lib-go. The fabric-ca dependency on fabric is no longer needed. That's good! Also ran goimports to clean up imports. Signed-off-by: David Enyeart <[email protected]>
denyeart
force-pushed
the
use_fabric_lib_go
branch
from
7808586
to
b40f1d6
Compare
|
Go approval in fabric repo to push down the dependency to fabric-lib-go, I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following packages are being moved from fabric to fabric-lib-go so that they can be shared across fabric and fabric-ca:
This commit updates fabric-ca to use the common code in fabric-lib-go.
The fabric-ca dependency on fabric is no longer needed. That's good!
Also ran goimports to clean up imports.